Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix qos bug #4866

Closed
wants to merge 2 commits into from
Closed

Fix qos bug #4866

wants to merge 2 commits into from

Conversation

dolibali
Copy link
Contributor

Signed-off-by: dolibali [email protected]

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes

Fixes #(issue-number)

Signed-off-by: dolibali <[email protected]>
@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. bug Something isn't working labels Dec 23, 2024
@coveralls
Copy link

coveralls commented Dec 23, 2024

Pull Request Test Coverage Report for Build 12475885613

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 4 of 11 (36.36%) changed or added relevant lines in 2 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.007%) to 22.133%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/daemon/controller_linux.go 0 3 0.0%
pkg/ovs/ovs-vsctl_linux.go 4 8 50.0%
Totals Coverage Status
Change from base Build 12434320848: 0.007%
Covered Lines: 10168
Relevant Lines: 45941

💛 - Coveralls

Signed-off-by: dolibali <[email protected]>
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Dec 24, 2024
@oilbeater
Copy link
Collaborator

ovs 的 ingress 和 egress 是从交换机端口的角度来看流量的,交换机端口的 ingress 对应的是 Pod 的 egress,我们这里的配置是从 Pod 角度来观察流量的。

@bobz965
Copy link
Collaborator

bobz965 commented Dec 24, 2024

ovs 的 ingress 和 egress 是从交换机端口的角度来看流量的,交换机端口的 ingress 对应的是 Pod 的 egress,我们这里的配置是从 Pod 角度来观察流量的。

这个我们在编码上改下命名加些注释吧

@dolibali dolibali closed this Dec 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants